Add event loop thread cpu usage #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOOP_INTERVAL so we can see if a Node.js process is CPU bound.
Update README.md
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 60.52% 60.71% +0.19%
==========================================
Files 49 49
Lines 3184 3200 +16
==========================================
+ Hits 1927 1943 +16
Misses 1257 1257
Continue to review full report at Codecov.
|
tobespc
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds cpu percentage used during the last measurement interval to the event loop statistics.
This is different from the cpu usage for the process it is just the measurement for the event loop thread.
See: RuntimeTools/appmetrics-dash#114 for more details on why this is required.
Currently this should work on Linux, Mac and AIX. Windows support could be added via a similar solution to: nodejs/node-report#99